Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(iotsitewise): add portal, project, gateway, dashboard, asset, asset model and access policy #420

Merged
merged 1 commit into from
Nov 18, 2024
Merged

feat(iotsitewise): add portal, project, gateway, dashboard, asset, asset model and access policy #420

merged 1 commit into from
Nov 18, 2024

Conversation

npellegrin
Copy link
Contributor

Closes #419

@npellegrin
Copy link
Contributor Author

New resource types:

  • IoTSiteWiseAsset
  • IoTSiteWiseAssetModel
  • IoTSiteWiseDashboard
  • IoTSiteWiseGateway
  • IoTSiteWisePortal
  • IoTSiteWiseProject
  • IoTSiteWiseAccessPolicy

Scan with feature activated:

eu-west-1 - IoTSiteWisePortal - 9446b069-b1ad-4a41-9d77-70b5df677cf2 - [name: "test Portal"] - would remove
eu-west-1 - IoTSiteWiseGateway - 65cb1349-be5d-42b1-ada5-13b2d459e8c9 - [name: "Gateway-B8Enr_b-p"] - would remove
eu-west-1 - IoTSiteWiseProject - 3a0aa9bf-bd59-4289-a86f-2e939cca0086 - [name: "test Project"] - would remove
eu-west-1 - IoTSiteWiseDashboard - bbe95e19-c7bc-447c-9a96-183fd694eef9 - [name: "New dashboard"] - would remove
eu-west-1 - IoTSiteWiseAsset - 06214240-7e09-4528-a002-c8e46f8217a3 - [name: "Oven_1", status: "ACTIVE"] - would remove
eu-west-1 - IoTSiteWiseAsset - c4acd8c3-9f56-4a0f-a44e-e98e4ea19922 - [name: "HorizontalConveyor_1", status: "ACTIVE"] - would remove
eu-west-1 - IoTSiteWiseAsset - 7bdf4401-7276-44f3-ac08-3cb133ba2c3d - [name: "testMaker_1", status: "ACTIVE"] - would remove
eu-west-1 - IoTSiteWiseAsset - 21388a7b-739c-4d27-82d7-dececb2b9560 - [name: "VerticalConveyor_1", status: "ACTIVE"] - would remove
eu-west-1 - IoTSiteWiseAsset - 051548cb-383a-4380-bad4-75086dead17b - [name: "Mixer_1", status: "ACTIVE"] - would remove
eu-west-1 - IoTSiteWiseAssetModel - 41dba598-ec81-465f-b96a-bad704924fe5 - [name: "Oven_Model", status: "ACTIVE"] - would remove
eu-west-1 - IoTSiteWiseAssetModel - 74bd3cd0-5798-4b3a-930c-b0a1e3469492 - [name: "Mixer_Model", status: "ACTIVE"] - would remove
eu-west-1 - IoTSiteWiseAssetModel - a3f6ff1f-4c29-4f45-8c80-b7a2f8b7f236 - [name: "testMaker_Model", status: "ACTIVE"] - would remove
eu-west-1 - IoTSiteWiseAssetModel - b5ea342a-260a-4cb3-9d21-b4a2c4198b8f - [name: "HorizontalConveyor_Model", status: "ACTIVE"] - would remove
eu-west-1 - IoTSiteWiseAssetModel - ba064ef9-1b60-44ed-a5e6-efb98e22172a - [name: "VerticalConveyor_Model", status: "ACTIVE"] - would remove
Scan complete: 14 total, 14 nukeable, 0 filtered.

Deletion log:

eu-west-1 - IoTSiteWisePortal - 9446b069-b1ad-4a41-9d77-70b5df677cf2 - [name: "test Portal"] - removed
eu-west-1 - IoTSiteWiseProject - 3a0aa9bf-bd59-4289-a86f-2e939cca0086 - [name: "test Project"] - removed
eu-west-1 - IoTSiteWiseAssetModel - 41dba598-ec81-465f-b96a-bad704924fe5 - [name: "Oven_Model", status: "ACTIVE"] - removed
eu-west-1 - IoTSiteWiseAssetModel - 74bd3cd0-5798-4b3a-930c-b0a1e3469492 - [name: "Mixer_Model", status: "ACTIVE"] - removed
eu-west-1 - IoTSiteWiseAssetModel - a3f6ff1f-4c29-4f45-8c80-b7a2f8b7f236 - [name: "testMaker_Model", status: "ACTIVE"] - removed
eu-west-1 - IoTSiteWiseAssetModel - b5ea342a-260a-4cb3-9d21-b4a2c4198b8f - [name: "HorizontalConveyor_Model", status: "ACTIVE"] - removed
eu-west-1 - IoTSiteWiseAssetModel - ba064ef9-1b60-44ed-a5e6-efb98e22172a - [name: "VerticalConveyor_Model", status: "ACTIVE"] - removed

Removal requested: 0 waiting, 0 failed, 0 skipped, 14 finished

@npellegrin npellegrin changed the title feat(iotsitewise): Add portal, project, gateway, dashboad, asset, asset model and access policy feat(iotsitewise): add portal, project, gateway, dashboad, asset, asset model and access policy Nov 17, 2024
@npellegrin npellegrin force-pushed the feature/iot-sitewise branch 2 times, most recently from 4db104f to 016335d Compare November 17, 2024 14:17
@npellegrin npellegrin changed the title feat(iotsitewise): add portal, project, gateway, dashboad, asset, asset model and access policy feat(iotsitewise): add portal, project, gateway, dashboard, asset, asset model and access policy Nov 17, 2024
@npellegrin npellegrin force-pushed the feature/iot-sitewise branch 2 times, most recently from dd09155 to 94d2096 Compare November 17, 2024 14:36
ekristen
ekristen requested changes Nov 17, 2024
View reviewed changes
Copy link
Owner

@ekristen ekristen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@npellegrin thanks for the PR. I'm working on standardizing the properties so that I can automatically generate documentation. Part of that change is to use exported properties on the structs in golang and use a new function types.NewPropertiesFromStruct(r).

  1. please rename all method pointers to r, I've made note on one of them so you can see.
  2. change all properties to capital word case, I've made note on one of them so you can see.
  3. change the properties to return types.NewPropertiesFromStruct(r)

resources/iotsitewise-access-policy.go Outdated Show resolved Hide resolved
resources/iotsitewise-access-policy.go Outdated Show resolved Hide resolved
@ekristen
Copy link
Owner

If you'd prefer I can push a commit to address these things. I'm happy to assist. I always prefer to give folks to the option. I appreciate you opening a PR for all this.

@npellegrin npellegrin force-pushed the feature/iot-sitewise branch 2 times, most recently from 99e1cf1 to 3e45e28 Compare November 17, 2024 22:08
@npellegrin
Copy link
Contributor Author

npellegrin commented Nov 17, 2024 •
edited
Loading

  • renamed all method pointers to r
  • changed all properties to capital word case
  • changed the properties to return types.NewPropertiesFromStruct(r)
  • Fixed a problem with asset hierarchy deletion

@npellegrin npellegrin requested a review from ekristen November 17, 2024 22:16
ekristen
ekristen approved these changes Nov 17, 2024
View reviewed changes
Copy link
Owner

@ekristen ekristen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes there is special provisions for maps and tags ;-)

@ekristen ekristen merged commit 674525d into ekristen:main Nov 18, 2024
4 checks passed
@ekristen
Copy link
Owner

🎉 This PR is included in version 3.30.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekristen ekristen ekristen approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[resource] IoTSiteWise
2 participants
@npellegrin @ekristen